-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added package-module-winget and needed dependency powershell-execution-policy #101
Added package-module-winget and needed dependency powershell-execution-policy #101
Conversation
03e5e20
to
cb97135
Compare
679c869
to
7748fbe
Compare
cacf3c4
to
5a35452
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the module input hasn't yet been updated to target the data namespace.
Minor suggestion of style for README mentioning variables (use verbatim)
Overall seems to make sense to me.
b14365d
to
435c9e3
Compare
435c9e3
to
f846ad1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good enough to me (without running it). I would target data
namspace explicitly with the module input.
And thinking about module input again, there must be some magic if it does default to the data
namespace, because variables in def.json (where module input ultimately lands) default to the default
namespace in the def
bundle.
Actually I just ran a test with cfbs, and it seems that namespace is required for input.
snippet of my cfbs.json whre I removed the namespace key for the input step for setting tar_url.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you must set namespace for module input.
…n-policy Ticket: ENT-12144
f846ad1
to
25fc72c
Compare
I didn't have to with cfbs 4.2.1 which is odd since we are both using that version. I suppose you are using a build index module and I am using a repo#commit. Maybe that's the diff. |
Ticket: ENT-12127